Skip to content

Settings CLI and remote apis#371

Open
kumare3 wants to merge 15 commits intomainfrom
settings-api
Open

Settings CLI and remote apis#371
kumare3 wants to merge 15 commits intomainfrom
settings-api

Conversation

@kumare3
Copy link
Copy Markdown
Contributor

@kumare3 kumare3 commented Dec 3, 2025

No description provided.

Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
@kumare3 kumare3 changed the title [WIP] Settings api Settings CLI and remote apis Mar 25, 2026
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>

# Get current settings
try:
settings = remote.Settings.get(project=project, domain=domain)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a get 'for edit', right? also probably we want the get for edit raw version - because this is what gives the unstructured map with the flattened keys.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, will update

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afbrock actually no, i want to get the entire heirarchy and then consolidate, show it to the user what was derived from where and then update. Maybe i dont understand the api. Why have 2 apis getforedit vs get

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get for edit returns all levels in a structure, and the current version for optimistic locking. get for edit raw gives the version and all levels in a flattened map. update /update raw corresponds to the two for edit calls. the simple get call just gets effective values for consumers rather than editors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants